Implement scoreboard filters #1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Herrera <pabloherrerapalacio@gmail.com>
67a905c to
85cfedf
Compare
Signed-off-by: Pablo Herrera <pabloherrerapalacio@gmail.com>
db70494 to
c8f769b
Compare
|
This has now been tested and works as intended 🎉 |
Electroid
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, has not been tested.
Should allow any objective to simply add a
scoreboard-filter="x"property, with a dynamic filter that says if it should show or not in the scoreboard. Additionally blitz and score modules also support it, and their filters apply for each competitor, so some may show while others do not