8000 refactor(platform/sportpaper): use NBT to store item tags by TTtie · Pull Request #1520 · PGMDev/PGM · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(platform/sportpaper): use NBT to store item tags #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2025

Conversation

TTtie
Copy link
Contributor
@TTtie TTtie commented Jun 25, 2025

Refactors the item tag subsystem on 1.8 to use platform-specific NBT storage. To prevent clashing with native tags, the tags are prefixed with PGM:, similarly to how they're namespaced on modern servers.

This allows for:

  • Expanded item tag storage for 1.8 servers
  • More data type possibilities (available codecs are nearly on-par with modern servers – maybe they could get some unit tests?)
  • Easier debugging on 1.8 servers for developers and map authors alike – using an NBT/component viewer mod, item-tagged options are viewable on items at a glance without needing to go to the map's XML to figure it out
Before After
A screenshot of a golden apple in a Bridge map showing just the lore, where all item tags are hidden A screenshot of a golden apple in a Bridge map showing prevent-sharing set to true and consumable to "bridge-apple"

@TTtie TTtie marked this pull request as ready for review July 6, 2025 19:16
@TTtie TTtie force-pushed the refactor/1.8-nbt-itemtags branch from 74b4a92 to 7c9519c Compare July 6, 2025 19:17
TTtie added 2 commits July 7, 2025 21:04
Refactors the item tag subsystem on 1.8 to use platform-specific NBT
storage. To prevent clashing with native tags, the tags are prefixed
with `PGM:`, just like on modern servers.

This allows for:
- Expanded item tag storage for 1.8 servers
- More data type possibilities (available codecs are nearly on-par with
  modern servers)
- Easier debugging on 1.8 servers for developers and map authors alike
  (using an NBT/component viewer mod)

Signed-off-by: TTtie <me@tttie.cz>
Signed-off-by: TTtie <me@tttie.cz>
@TTtie TTtie force-pushed the refactor/1.8-nbt-itemtags branch from 7c9519c to 6ffbe90 Compare July 7, 2025 21:04
@Pablete1234 Pablete1234 merged commit a530af3 into PGMDev:dev Jul 12, 6F14 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0