8000 [Upstream] [Budget] Make sorting of finalized budgets deterministic by lyricidal · Pull Request #106 · PRCYCoin/PRCYCoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Upstream] [Budget] Make sorting of finalized budgets deterministic #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2021
Merged

[Upstream] [Budget] Make sorting of finalized budgets deterministic #106

merged 1 commit into from
Sep 2, 2021

Conversation

lyricidal
Copy link

When there are 2 (or more) finalized(!) budgets (that's a valid condition) and both have the same voting count it's not deterministic which one is used to pay the monthly budgets and the network might not agree on a payment at all.

The worst possible result of this race-condition is that the network gets stuck one block before the budgets payments start, because one half of the network rejects the budgets payments of the other half.

This PR makes sorting and therefore the selection of the finalized budget deterministic and avoids this scenario.

from PIVX-Project/PIVX#608

We currently don't use Budgets, but keeping in line with Upstream.

@lyricidal lyricidal requested review from lopeed and anprdev September 2, 2021 15:59
@lopeed lopeed merged commit 5797451 into develop Sep 2, 2021
@lopeed lopeed deleted the upstream-finalized_budgets_sort branch September 2, 2021 16:02
anprdev
anprdev reviewed Sep 2, 2021
View reviewed changes
Copy link
@anprdev anprdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job

@lyricidal lyricidal added the Upstream Upstream backports/fixes label Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anprdev anprdev anprdev left review comments

@lopeed lopeed Awaiting requested review from lopeed

Assignees
No one assigned
Labels
Upstream Upstream backports/fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lyricidal @anprdev @lopeed
0