8000 [Upstream] [Refactor] Init wallet parameters interaction by lyricidal · Pull Request #127 · PRCYCoin/PRCYCoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Upstream] [Refactor] Init wallet parameters interaction #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 29, 2021
Merged

[Upstream] [Refactor] Init wallet parameters interaction #127

merged 3 commits into from
Sep 29, 2021

Conversation

lyricidal
Copy link

This PR does two things:

  1. Move the pwalletMain object inside the wallet.h file.
  2. Move the wallet's parameters initialization to an static method ParameterInteraction in the wallet class.

This is coming (partially) from upstream 25340b7 .

from PIVX-Project/PIVX#1445

@lyricidal lyricidal added the Upstream Upstream backports/fixes label Sep 29, 2021
@lyricidal lyricidal requested review from lopeed and anprdev September 29, 2021 18:12
@lopeed lopeed merged commit 5db8150 into develop Sep 29, 2021
@lopeed lopeed deleted the upstream-wallet_parameters_setup branch September 29, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lopeed lopeed lopeed approved these changes

@anprdev anprdev Awaiting requested review from anprdev

Assignees
No one assigned
Labels
Upstream Upstream backports/fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyricidal @lopeed
0