8000 [Upstream] [GUI] Show disk space requirement per-network by lyricidal · Pull Request #155 · PRCYCoin/PRCYCoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Upstream] [GUI] Show disk space requirement per-network #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2021
Merged

[Upstream] [GUI] Show disk space requirement per-network #155

merged 1 commit into from
Nov 16, 2021

Conversation

lyricidal
Copy link

This introduces per-network required disk space into the intro UI in the least intrusive way for now. Mainnet and Testnet have their own static const variables, whereas Regtest is always set to "0"

This is intended as a temporary fix for #2618, with future intention on moving these over to chainparams a la upstream and using a node IPC interface layer, which we do not have yet.

Can be tested by passing -choosedatadir with a combination of -testnet, -regtest, or standalone, and this has zero impact on translation strings.

from PIVX-Project/PIVX#2621

Quote adjusted as we don't have choosedatadir yet

@lyricidal
[GUI] Show disk space requirement per-network
e4a84c7 
This introduces per-network required disk space into the intro UI in the least intrusive way for now. Mainnet and Testnet have their own static const variables, whereas Regtest is always set to "0".
@lyricidal lyricidal added the Upstream Upstream backports/fixes label Nov 16, 2021
@lyricidal lyricidal requested review from lopeed and anprdev November 16, 2021 18:17
@lopeed lopeed merged commit 886b61e into develop Nov 16, 2021
@lopeed lopeed deleted the upstream-intro-per-network-size branch November 16, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lopeed lopeed lopeed approved these changes

@anprdev anprdev Awaiting requested review from anprdev

Assignees
No one assigned
Labels
Upstream Upstream backports/fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyricidal @lopeed
0