8000 [Upstream] [net] Remove assert(nMaxInbound > 0) by lyricidal · Pull Request #260 · PRCYCoin/PRCYCoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Upstream] [net] Remove assert(nMaxInbound > 0) #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2022
Merged

[Upstream] [net] Remove assert(nMaxInbound > 0) #260

merged 1 commit into from
Aug 21, 2022

Conversation

lyricidal
Copy link

Backports bitcoin#9008.

nMaxInbound might very well be 0 or -1, if the user prefers to keep a small number of maxconnections.
Note: nMaxInbound of -1 means that the user set maxconnections
to 8 or less, but we still want to keep an additional slot for
the feeler connection.

Have faced this assertion crash few times in testnet already.

from PIVX-Project/PIVX#2682

@lyricidal
[net] Remove assert(nMaxInbound > 0)
9075206 
nMaxInbound might very well be 0 or -1, if the user prefers to keep
a small number of maxconnections.

Note: nMaxInbound of -1 means that the user set maxconnections
to 8 or less, but we still want to keep an additional slot for
the feeler connection.
@lyricidal lyricidal added the Upstream Upstream backports/fixes label Aug 21, 2022
@lyricidal lyricidal merged commit 92e7898 into develop Aug 21, 2022
@lyricidal lyricidal deleted the upstream-nMaxInbound-pr2682 branch August 21, 2022 20:15
lopeed pushed a commit that referenced this pull request Nov 3, 2022
@Jenova7
Merge pull request #260 from Jenova7/master
b26739f 
remove block version check before the fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anprdev anprdev anprdev approved these changes

@Shenkyy Shenkyy Awaiting requested review from Shenkyy

@lopeed lopeed Awaiting requested review from lopeed

@lucablighthl lucablighthl Awaiting requested review from lucablighthl

@UserR256 UserR256 Awaiting requested review from UserR256

@Jamesj66 Jamesj66 Awaiting requested review from Jamesj66

@apophis1329 apophis1329 Awaiting requested review from apophis1329

Assignees
No one assigned
Labels
Upstream Upstream backports/fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyricidal @anprdev
0