[Upstream] [Build][Cleanup] Tidy up the gitian build descriptors #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes regression introduced by bitcoin/bitcoin#16141 -BEGIN VERIFY SCRIPT- sed -i 's#\$REFERENCE_DATE\\\\\\ \$REFERENCE_TIME#\$REFERENCE_DATETIME#g' contrib/gitian-descriptors/* -END VERIFY SCRIPT-
This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (bitcoin/bitcoin#6900). However, it should no longer be required, as we have switched to Bionic (bitcoin/bitcoin#13171), and that has a far newer version of binutils. binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192
Debug splitting was first introduced in PIVX-Project/PIVX@7e7eb27, then gitian-linux.yml changed to using split-debug.sh in PIVX-Project/PIVX@9d25362. Here we change gitian-win.yml to use split-debug.sh as well.
Linux: The README was originally added in PIVX-Project/PIVX@8550f1f, but included the README under the docs directory, which has a bunch of internal links that won't make sense in a release tarball. In this patch, we include the root level README instead, which makes more sense. Windows: .md files are inconvenient to open on windows and the line endings differ, so we use README_windows.txt instead. master (#2447)
We no longer build/ship 32 bit windows executables.
configure.ac defines the `PACKAGE_URL` variable during init, so use that in the windows packaging nsi script instead of a static string.
Shenkyy
approved these changes
Oct 3, 2022
<
8000
div data-view-component="true" class="TimelineItem-body my-0">
UserR256
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from PIVX-Project/PIVX#2447