8000 [Upstream] [Staking] Improved Staking Flow by lyricidal · Pull Request #320 · PRCYCoin/PRCYCoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Upstream] [Staking] Improved Staking Flow #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Dec 28, 2022
Merged

[Upstream] [Staking] Improved Staking Flow #320

merged 16 commits into from
Dec 28, 2022

Conversation

lyricidal
Copy link

The first of a number of staking improvements. This is based on: PIVX-Project/PIVX#582

There will be a number of follow ups, broken up for easier review/testing, leading up to PoSv2 / Time Protocol v2 and beyond.

@lyricidal
New Staking Flow
1774291
@lyricidal
[Staking] Fix MintableCoins and fMintableCoins
3d71209 
This fixes an edge case where `fMintableCoins` evaluates to `false`
during initialization, which was causing an infinate loop in the staking
thread.
@lyricidal
[Miner] Remove minersleep
4407786
@lyricidal
Remove uneeded lock on createcoinstake().
40cc36c
@lyricidal
Do not try to add all stakes on init
250c93a
@lyricidal
Remove balance check from CreateCoinStake().
b04918d
@lyricidal
[Staking] Fix Stake Split Threshold for PRCY staking
3778191 
This reintroduces the calculation on wither or not the wallet should
"split" the PRCY stake input.

Currently remains disabled.
@lyricidal
More efficient scanning during zapwallettxes.
ae31a50
@lyricidal
Use smart pointers to keep better track of memory.
1b17d69 
- Change the CheckProofOfStake() process to use unique_ptr.
@lyricidal
Use unique_ptr for stake input list.
c35f679
@lyricidal
[Staking] Exit CreateCoinStake loop if wallet locked/shutdown
82491a2 
If the wallet gets locked or a shutdown is requested in the middle of
the stakeinput loop, there is no sense in continuing.
@lyricidal
Simplify and document -custombackupthreshold
b3d5a95 
Also move -backuppath to more appropriate area in the help output.
@lyricidal
Cleanup log spam
3619705
@lyricidal
Display -backuppath, -custombackupthreshold in wallet repair menu
df2c888 
also fix segfault when permission denied since trying to create directories before checking permissions
@lyricidal
Guard against non-integer input for GUI's custombackupthreshold
482a50a
@lyricidal
Restore lock in CreateCoinStake()
86ba1cf
@lyricidal lyricidal added enhancement New feature or request Upstream Upstream backports/fixes labels Dec 28, 2022
@lyricidal lyricidal merged commit 7867a31 into develop Dec 28, 2022
@lyricidal lyricidal deleted the upstream-staking_flow-pr582 branch December 28, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anprdev anprdev anprdev approved these changes

@Shenkyy Shenkyy Awaiting requested review from Shenkyy

@lopeed lopeed Awaiting requested review from lopeed

@lucablighthl lucablighthl Awaiting requested review from lucablighthl

@UserR256 UserR256 Awaiting requested review from UserR256

@Jamesj66 Jamesj66 Awaiting requested review from Jamesj66

@apophis1329 apophis1329 Awaiting requested review from apophis1329

Assignees
No one assigned
Labels
enhancement New feature or request Upstream Upstream backports/fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyricidal @anprdev
0