8000 [Upstream] [Build] Clean all coverage files during make clean by lyricidal · Pull Request #372 · PRCYCoin/PRCYCoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Upstream] [Build] Clean all coverage files during make clean #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2023
Merged

[Upstream] [Build] Clean all coverage files during make clean #372

merged 1 commit into from
Feb 23, 2023

Conversation

lyricidal
Copy link

This adds extra paths that were left out and ensures that .gcda and .gcno files are properly cleaned up.

Simple way to test this is to run the following chain of commands both without and with the changeset:

./configure --enable-lcov
make
make clean && make distclean
find . -name "*.gcno"

Without this, there are leftover (non-cleaned) .gcno files, which could cause errors due to stale or fragmented/incomplete information when attempting to generate the coverage report (make cov). With this change, the find command shows that no such .gcno files remain after cleaning.

This all requires that lcov is available on the system, as configure will properly error out when using the --enable-lcov option if it isn't found.

from PIVX-Project/PIVX#910 with some updates for additional paths that we have from more recent backports.

@lyricidal
[Build] Clean all coverage files during make clean
fc8e33a 
This adds extra paths that were left out and en
8000
sures that `.gcda` and `
.gcno` files are properly cleaned up.
@lyricidal lyricidal added the Upstream Upstream backports/fixes label Feb 23, 2023
@lyricidal lyricidal merged commit 1f4e22c into develop Feb 23, 2023
@lyricidal lyricidal deleted the upstream-clean_lcov-pr910 branch February 23, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anprdev anprdev anprdev approved these changes

@Shenkyy Shenkyy Awaiting requested review from Shenkyy

@lopeed lopeed Awaiting requested review from lopeed

@lucablighthl lucablighthl Awaiting requested review from lucablighthl

@UserR256 UserR256 Awaiting requested review from UserR256

@Jamesj66 Jamesj66 Awaiting requested review from Jamesj66

@apophis1329 apophis1329 Awaiting requested review from apophis1329

Assignees
No one assigned
Labels
Upstream Upstream backports/fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyricidal @anprdev
0