hif: Initial comps group support. #49
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit d52967c Author: Helio Chissini de Castro <helio@kde.org> Date: Wed Feb 18 12:59:15 2015 -0200 - Fix proper return call. commit 2804bee Author: Helio Chissini de Castro <helio@kde.org> Date: Mon Jan 12 18:52:46 2015 -0200 - Identation fixes Signed-off-by: Helio Chissini de Castro <helio@kde.org> commit 9c1e7cb Author: Helio Chissini de Castro <helio@kde.org> Date: Mon Jan 12 18:43:04 2015 -0200 - Return directly the array Signed-off-by: Helio Chissini de Castro <helio@kde.org> commit bfae846 Author: Helio Chissini de Castro <helio@kde.org> Date: Mon Jan 12 17:23:20 2015 -0200 - Fix void return. Now it addresses failt or not on parsing. - More identation fixes Signed-off-by: Helio Chissini de Castro <helio@kde.org> commit ee0d1d8 Author: Helio Chissini de Castro <helio@kde.org> Date: Thu Dec 11 11:07:29 2014 -0200 - Use pk_package_id_build instead of older build method based on template sample - More identation fixing Signed-off-by: Helio Chissini de Castro helio@kde.org commit 4ad973b Author: Helio Chissini de Castro <helio@kde.org> Date: Tue Dec 9 16:41:12 2014 -0200 - Move static for structure PkCompsData - Use user_data on GMarkup parser functions - Fix more identation from original code Signed-off-by: Helio Chissini de Castro helio@kde.org commit 3adb3d3 Author: Helio Chissini de Castro <helio@kde.org> Date: Tue Dec 2 18:43:41 2014 -0200 - Fixed identation issues as reported Signed-off-by: Helio Chissini de Castro <helio@kde.org> commit 30d19e4 Author: Helio Chissini de Castro <helio@kde.org> Date: Tue Dec 2 17:49:27 2014 -0200 - Initial support to comps xml parsing. Enable hif backend to search categories and do a simple category mapping. TODO: - Add dynamic categories - Replace package query function to a proper libhif function Signed-off-by: Helio Chissini de Castro <helio@kde.org>
backends/hif/pk-backend-hif.c
Outdated
| g_ptr_array_add (comps_data->groups, g_strdup(text)); | ||
| } | ||
| if (comps_data->category_state == COMPS_STATE_GROUP_DESCRIPTION) { | ||
| g_debug ("Description: %s\n", text); |
There was a problem hiding this comment.
No newline for g_debug required.
* no \n needed after g_debug * break 2 too long lines after && * change 4 occurrences of == FALSE to !
|
Fixed all of the above and 2 more occurrences of |
|
Ping? I addressed all your comments, can this be merged now? |
|
This needs rebasing and further work. Please reopen if you still want to do this work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a squashed version of @heliocastro's patch set that adds comps support to the hif backend:
Initial support for comps XML parsing. Enable the hif backend to search categories and do a simple mapping of comps categories/groups to PackageKit's static groups.
TODO: support for PackageKit dynamic categories.
Supersedes pull request #20.