apt: Fix updated and issued dates on changelog parsing #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba4cf96 to
a70bd27
Compare
|
I think it would be better to add a testcase to https://github.com/PackageKit/PackageKit/blob/main/backends/apt/tests/apt-tests.cpp. |
a70bd27 to
2a3bcff
Compare
Fixes the parsing of the changelog dates, which resulted on the
`issued` and `updated` date parameters never getting filled.
According to `deb-changelog` specification, the dates in the apt
changelog entries do not follow RFC1123 format (which doesn't handle
timezones), but is compatible with RFC2822/RFC5322, that is:
"day-of-week, dd month yyyy hh:mm:ss +zzzz"
Also, rework the conditions to check first for the changelog date
line (starts with " --") so it doesn't get shadowed by the general
condition (starts with " ")
Adds a test case for the new conversion function
2a3bcff to
e6ec178
Compare
Sure! Added a test case for the conversion function Testing the whole |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the parsing of the changelog dates, which resulted on the
issuedandupdateddate parameters never getting filled.According to
deb-changelogspecification, the dates in the apt changelog entries do not follow RFC1123 format (which doesn't handle timezones), buut is compatible with RFC2822/RFC5322, that is:"day-of-week, dd month yyyy hh:mm:ss +zzzz"
Also, rework the conditions to check first for the changelog date line (starts with " --") so it doesn't get shadowed by the general condition (starts with " ")
Some examples of the reported dates on the client side, by adding some debug output to discover: