Refine documents of PARL #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- remove not used files
- add benchmark for DQN and DDPG
- add Parameters management Readme
- fix dependence of examples
added 2 commits
January 16, 2019 16:23
added 14 commits
January 16, 2019 16:45
TomorrowIsAnOtherDay
requested changes
Jan 18, 2019
parl/framework/model_base.py
Outdated
| @@ -124,23 +124,39 @@ class Model(Network): | |||
| In conclusion, Model is responsible for forward and | |||
| Algorithm is responsible for backward. | |||
|
|
|||
| Model can also be used to construct target model, which has the same structure as initial model. | |||
| Model can also use deepcopy way to construct target model, which has the same structure as initial model. | |||
| Note that parameters in the initial model havn't been copied to target model. | |||
There was a problem hiding this comment.
Note that only the model definition are copied here. To copy the parameters from the current model to the target model, you must explicitly use sync_params_to function after the program is initialized.
parl/layers/layer_wrappers.py
Outdated
| @@ -13,6 +13,21 @@ | |||
| # limitations under the License. | |||
| """ | |||
| Wrappers for fluid.layers so that the layers can share parameters conveniently. | |||
There was a problem hiding this comment.
Wrappers for fluid.layers. It helps to easily share parameters between layers.
TomorrowIsAnOtherDay
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.