fix norm outputs in dynamic and static mode #9569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
|
d70029e to
ca1a475
Compare
DrownFish19
reviewed
Dec 12, 2024
| @@ -741,7 +741,7 @@ def get_weight_create_dype(self): | |||
|
|
|||
| def compute_layernorm_before_qkv(self, src, i): | |||
| if i == 0: | |||
| ln_out = self.norm_func(src, self.ln_scales[i], self.ln_biases[i], self._epsilon, begin_norm_axis=1) | |||
| ln_out = self.norm_func(src, self.ln_scales[i], self.ln_biases[i], self._epsilon, begin_norm_axis=1)[0] | |||
There was a problem hiding this comment.
对的，不兼容升级，需要对应paddlepaddle最新的版本
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9569 +/- ##
===========================================
- Coverage 52.83% 52.77% -0.07%
===========================================
Files 701 709 +8
Lines 110577 111172 +595
===========================================
+ Hits 58427 58672 +245
- Misses 52150 52500 +350 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ca1a475 to
0a1476a
Compare
yuanlehome
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
fix norm has different outputs in dynamic mode and static mode
PaddlePaddle/Paddle#69960