[llm]add bf16 moment adamw #9732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9732 +/- ##
===========================================
- Coverage 51.41% 51.03% -0.39%
===========================================
Files 745 745
Lines 118351 119410 +1059
===========================================
+ Hits 60856 60939 +83
- Misses 57495 58471 +976 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for your contribution! |
wawltor
reviewed
Feb 25, 2025
| @@ -0,0 +1,15 @@ | |||
| # Copyright (c) 2024 PaddlePaddle Authors. All Rights Reserved. | |||
| # Update param | ||
| if master_weight_ptr is not None: | ||
| tl.store(master_weight_ptr + offsets, param, mask=mask) | ||
| tl.store(param_ptr + offsets, param.to(tl.bfloat16), mask=mask) |
There was a problem hiding this comment.
这里设计的需要考虑下optimizer原始参数的dtype，是否考虑float16的场景，开源模型部分模型是float16
| BLOCK_SIZE: tl.constexpr, | ||
| ): | ||
| pid = tl.program_id(0) | ||
| offsets = pid * BLOCK_SIZE + tl.arange(0, BLOCK_SIZE) |
There was a problem hiding this comment.
我理解是要读取[0, BLOCK_SIZE 8000 ]所有tensor进行操作
paddlenlp/utils/optimizer.py
Outdated
| @@ -149,3 +154,227 @@ def adamw_python( | |||
| beta1_pow[:], beta2_pow[:] = beta1 * beta1_pow[:], beta2 * beta2_pow[:] | |||
| # 看看怎么更新 | |||
| return | |||
|
|
|||
|
|
|||
| class AdamWPython(AdamW): | |||
There was a problem hiding this comment.
这个名字是不是有点奇怪，是不是朴素实现，或者 AdamWSlow之类的更合适点
wawltor
reviewed
Feb 25, 2025
| type = core.VarDesc.VarType.DENSE_TENSOR | ||
| except: | ||
| type = core.VarDesc.VarType.LOD_TENSOR | ||
| self._add_accumulator( |
There was a problem hiding this comment.
论文中的beta1和beta2是float32是吗？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
使用只需要增加 --optim adamw_16bit_moment