10000 [requirements] tokenizers for py38 by DrownFish19 · Pull Request #9953 · PaddlePaddle/PaddleNLP · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[requirements] tokenizers for py38 #9953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

[requirements] tokenizers for py38 #9953

merged 1 commit into from
Feb 27, 2025

Conversation

DrownFish19
Copy link
Collaborator

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Others

PR changes

Others

Description

The tokenizers package cannot be installed directly in Python 3.8.

@paddle-bot Paddle-bot
Copy link
paddle-bot bot commented Feb 27, 2025

Thanks for your contribution!

@DrownFish19 DrownFish19 changed the title [requirements] tokenziers for py38 [requirements] tokenizers for py38 Feb 27, 2025
@codecov Codecov
Copy link
codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.08%. Comparing base (347d77c) to head (9c41d66).
Report is 351 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #9953      +/-   ##
===========================================
- Coverage    51.34%   51.08%   -0.26%     
===========================================
  Files          745      745              
  Lines       118567   119261     +694     
===========================================
+ Hits         60877    60926      +49     
- Misses       57690    58335     +645

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ZHUI
ZHUI reviewed Feb 27, 2025
View reviewed changes
Copy link
Collaborator
@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 00f1e66 into PaddlePaddle:develop Feb 27, 2025
7 of 12 checks passed
@DrownFish19 DrownFish19 deleted the dev_20250227_fix_requirements branch February 27, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZHUI ZHUI ZHUI left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrownFish19 @ZHUI
0