Fix portal create event block list #12373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's fair, but generally this event call is weird because:
|
|
My testing was for lighting an already-created (player-built) portal, meaning the obsidian already exists in that context. Looking at the code for exit portal generation, I can't seem to find where the obsidian is actually set in the level. In my case, though, I'm able to modify the obsidian because it's not part of the portal's creation. |
kennytv
approved these changes
Apr 22, 2025
lynxplay
approved these changes
Apr 24, 2025
|
Agree with lulu, the event is in a bit of a weird place there but yea, w/e, not part of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic for the portal gets the portal blocks incorrectly. It retrieves blocks in a diagonal line, as seen below (the two lime wool are part of this incorrect line). This PR changes the variable used to correctly align the blocks retrieved.
