Multi weekly alarm #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 13, 2019
Closed
|
@bvandaele Did you check this is working for Fridays and Saturdays? I don't know why but I'm using your branch but Fridays and Saturdays, when it performs the scheduler it starts calling every time to the callback |
tonilopezmr
suggested changes
Dec 1, 2019
TimeAlarms.cpp
Outdated
| // if this is a multi weekly alarm | ||
| boolean updated = false; | ||
|
|
||
| for (int dayIndex = (dowSunday-1); dayIndex != (dowSaturday-1); dayIndex++) { |
There was a problem hiding this comment.
This loop is missing Friday and Saturday, is going from (0 to 5)
for (int dayIndex = (dowSunday); dayIndex <= (dowSaturday); dayIndex++) {There was a problem hiding this comment.
Thank you for your feedback. I just committed a fix.
And sorry for the delay
|
@tonilopezmr Did this ever get merged? It looks like it works now and this would be pretty sweet to have in the main build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I submit this pull request to offer a new functionality to be able to specify an alarm to be triggered multiple days every week. For example every Monday and Tuesday.
I needed this and i hope it could help others.