8000 Revert "[PAN-2789] Add ethSigner acceptance test (#1655)" by ajsutton · Pull Request #1888 · PegaSysEng/pantheon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Sep 26, 2019. It is now read-only.

Revert "[PAN-2789] Add ethSigner acceptance test (#1655)" #1888

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

ajsutton
Copy link
Contributor

This reverts commit b023831.

The new test runs EthSigner listening on a hard coded port 8545. This will result in intermittent port conflicts. One of which is with tech.pegasys.pantheon.tests.acceptance.RpcApisTogglesAcceptanceTest.shouldFailConnectingToNodeWithJsonRpcDisabled which expects that port 8545 is not listening but is now getting an error from EthSigner.

The test needs to be rewritten to specify port 0 so EthSigner selects a free port dynamically in the same way that is used with Pantheon.

@ajsutton ajsutton merged commit 0dc4b86 into PegaSysEng:master Aug 27, 2019
@ajsutton ajsutton deleted the revert-ethsigner branch August 27, 2019 22:03
pscott pushed a commit to pscott/pantheon that referenced this pull request Sep 2, 2019
…egaSysEng#1888)

This reverts commit b023831. Causes intermittency because of hard coded port 8545.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0