This repository was archived by the owner on Sep 26, 2019. It is now read-only.
Revert "[PAN-2789] Add ethSigner acceptance test (#1655)" #1888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b023831.
The new test runs EthSigner listening on a hard coded port 8545. This will result in intermittent port conflicts. One of which is with tech.pegasys.pantheon.tests.acceptance.RpcApisTogglesAcceptanceTest.shouldFailConnectingToNodeWithJsonRpcDisabled which expects that port 8545 is not listening but is now getting an error from EthSigner.
The test needs to be rewritten to specify port 0 so EthSigner selects a free port dynamically in the same way that is used with Pantheon.