8000 all: please remove uses of log.Fatal* as they don't allow any recoveries nor cleanups and immediately invoke os.Exit · Issue #294 · PeggyJV/sommelier · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
all: please remove uses of log.Fatal* as they don't allow any recoveries nor cleanups and immediately invoke os.Exit #294
New issue
New issue
Open
Open
all: please remove uses of log.Fatal* as they don't allow any recoveries nor cleanups and immediately invoke os.Exit#294
@odeke-em

Description

@odeke-em
odeke-em
opened on Mar 15, 2024

Summary of Bug

If we look at this code

sommelier/app/export.go

Lines 59 to 63 in 3157d97

for _, addr := range jailAllowedAddrs {
_, err := sdk.ValAddressFromBech32(addr)
if err != nil {
log.Fatal(err)
}
and

sommelier/app/export.go

Line 178 in 3157d97

log.Fatal(err)
we can see the invocation of log.Fatal which will immediately terminate the program having invoked os.Exit, not allowing for any deferred cleanups. Even more, the code all around it uses panic(err)
image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      0