PeggyJV/sommelier

Dockerfile does not copy genesis or app.toml during build

#338

· no-no-genesis opened

on Apr 8, 2025

Upgrade to Cosmos SDK 0.47

#309

· cbrit opened

on Jul 22, 2024

x/cellarfees/keeper: remove unnecessary iterations predicated on an AND condition that could be checked immediately that an auction interval occured

#300

· odeke-em opened

on Mar 15, 2024

x/axelarcork/keeper, x/cork/keeper: HandleRemoveManagedCellarsProposal should bail out immediately found=true to avoid needless/wasted iterations

#299

· odeke-em opened

on Mar 15, 2024

all: can avoid the use of bytes.Buffer and .Next simply by reslicing, since bytes.NewBuffer has an allocation and CPU time cost

#298

· odeke-em opened

on Mar 15, 2024

x/auction/keeper: IterateAuctions and other helpers should be returning pointers to unmarshalled objects to avoid awkward APIs that consume pointers yet receive values

#297

· odeke-em opened

on Mar 15, 2024

nit: x/auction/keeper: Keeper.EndBlocker could succinctly use !sdk.Dec.IsPositive and not having to compare against a zero magnitude sdk.Dec

#296

· odeke-em opened

on Mar 15, 2024

app: (*SommelierApp).prepForZeroHeightGenesis should instead use a defer iter.Close() to ensure that the store gets closed on any panic

#295

· odeke-em opened

on Mar 15, 2024

all: please remove uses of log.Fatal* as they don't allow any recoveries nor cleanups and immediately invoke os.Exit

#294

· odeke-em opened

on Mar 15, 2024

all: use of cosmossdk.io/math.ParseUint then cast to uint32 is unnecessary and susceptible to uint64->uint32 underflows which could be a security issue

#292

· odeke-em opened

on Mar 13, 2024

Generalized eth <-> somm address mapping state

enhancement

#288

· cbrit opened

on Mar 4, 2024

Sommelier v8

#287

· cbrit opened

on Mar 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dockerfile does not copy genesis or app.toml during build

Upgrade to Cosmos SDK 0.47

x/cellarfees/keeper: remove unnecessary iterations predicated on an AND condition that could be checked immediately that an auction interval occured

x/axelarcork/keeper, x/cork/keeper: HandleRemoveManagedCellarsProposal should bail out immediately found=true to avoid needless/wasted iterations

all: can avoid the use of bytes.Buffer and .Next simply by reslicing, since bytes.NewBuffer has an allocation and CPU time cost

x/auction/keeper: IterateAuctions and other helpers should be returning pointers to unmarshalled objects to avoid awkward APIs that consume pointers yet receive values

nit: x/auction/keeper: Keeper.EndBlocker could succinctly use !sdk.Dec.IsPositive and not having to compare against a zero magnitude sdk.Dec

app: (*SommelierApp).prepForZeroHeightGenesis should instead use a defer iter.Close() to ensure that the store gets closed on any panic

all: please remove uses of log.Fatal* as they don't allow any recoveries nor cleanups and immediately invoke os.Exit

all: use of cosmossdk.io/math.ParseUint then cast to uint32 is unnecessary and susceptible to uint64->uint32 underflows which could be a security issue

Generalized eth <-> somm address mapping state

Sommelier v8

Issues

Search results