8000 [ENH] Update pyafq; add pyafq full test by 36000 · Pull Request #533 · PennLINC/qsiprep · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[ENH] Update pyafq; add pyafq full test #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 10, 2023

Conversation

36000
Copy link
Contributor
@36000 36000 commented Mar 9, 2023

This PR updates pyAFQ to 1.0.1 and adds a test for the "full" run of pyafq (use dipy tractography instead of mrtrix). Also updates names/docs of pyAFQ to be more clear.

@36000 36000 changed the title [Update pyafq; add pyafq full test [ENH] Update pyafq; add pyafq full test Mar 9, 2023
@mattcieslak
Copy link
Collaborator

@36000 let me know when you'd like a review and I'll merge this

@36000
Copy link
Contributor Author
36000 commented Mar 9, 2023

@mattcieslak ready for review / merge!

@36000
Copy link
Contributor Author
36000 commented Mar 9, 2023

@mattcieslak actually, hold up on merging this. I want to see if it resolves one of the posted issues first.

@richford
Copy link
Contributor

@mckenziephagen and I are anxiously awaiting this merge! We'll use it to kick off the ABCD pyAFQ runs. Thanks so much @mattcieslak and @36000!

@mattcieslak mattcieslak merged commit 8080311 into PennLINC:master Mar 10, 2023
@richford
Copy link
Contributor

Wow! That was fast. @mattcieslak, any chance you could cut a release or RC with this?

@mattcieslak
Copy link
Collaborator

0.17.0 should be up in a bit. @36000 are there any shortcuts to make the CI test run faster? It looks like it's taking 90 minutes to run as it's currently implemented

@36000
Copy link
Contributor Author
36000 commented Mar 11, 2023

I think the easiest thing to do would be to reduce the number of seeds for tractography and/or comment out one of the two portions of the test. I will make a PR that does this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0