-
Notifications
You must be signed in to change notification settings - Fork 58
[ENH] Update pyafq; add pyafq full test #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@36000 let me know when you'd like a review and I'll merge this |
@mattcieslak ready for review / merge! |
@mattcieslak actually, hold up on merging this. I want to see if it resolves one of the posted issues first. |
@mckenziephagen and I are anxiously awaiting this merge! We'll use it to kick off the ABCD pyAFQ runs. Thanks so much @mattcieslak and @36000! |
Wow! That was fast. @mattcieslak, any chance you could cut a release or RC with this? |
0.17.0 should be up in a bit. @36000 are there any shortcuts to make the CI test run faster? It looks like it's taking 90 minutes to run as it's currently implemented |
I think the easiest thing to do would be to reduce the number of seeds for tractography and/or comment out one of the two portions of the test. I will make a PR that does this tomorrow. |
This PR updates pyAFQ to 1.0.1 and adds a test for the "full" run of pyafq (use dipy tractography instead of mrtrix). Also updates names/docs of pyAFQ to be more clear.