8000 Remove unused source_file parameter from CombineMotions by tsalo · Pull Request #943 · PennLINC/qsiprep · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove unused source_file parameter from CombineMotions #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Remove unused source_file parameter from CombineMotions #943

merged 1 commit into from
Apr 28, 2025

Conversation

tsalo
Copy link
Member
@tsalo tsalo commented Apr 28, 2025

Closes none, but is related to #301. In #301, the source_file parameter in CombineMotions became unused, so this PR just removes the parameter to make the code more readable.

Changes proposed in this pull request

  • Remove source_file from CombineMotions and clean up related functions and workflows.

@tsalo tsalo added the refactor Changes to the codebase that don't impact workflow inputs or outputs. label Apr 28, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.02%. Comparing base (00c73c4) to head (071a8ac).

Files with missing lines Patch % Lines
qsiprep/interfaces/gradients.py 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #943      +/-   ##
==========================================
- Coverage   46.02%   46.02%   -0.01%     
==========================================
  Files          65       65              
  Lines        9764     9763       -1     
  Branches     1072     1072              
==========================================
- Hits         4494     4493       -1     
  Misses       5044     5044              
  Partials      226      226

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsalo tsalo requested a review from mattcieslak April 28, 2025 17:52
mattcieslak
mattcieslak approved these changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator
@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember now why src and ref file are the same image - all these images are in the same field of view

@tsalo tsalo merged commit c74ff2f into master Apr 28, 2025
24 checks passed
@tsalo tsalo deleted the simplify-hmc branch April 28, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcieslak mattcieslak mattcieslak approved these changes

Assignees
No one assigned
Labels
refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsalo @codecov-commenter @mattcieslak
0