8000 Add ng, perng, parng, and mapcoeffs to Dipy MAPMRI outputs by tsalo · Pull Request #55 · PennLINC/qsirecon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add ng, perng, parng, and mapcoeffs to Dipy MAPMRI outputs #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 16, 2024
Merged

Add ng, perng, parng, and mapcoeffs to Dipy MAPMRI outputs #55

merged 6 commits into from
Aug 16, 2024

Conversation

tsalo
Copy link
Member
@tsalo tsalo commented Aug 15, 2024 •
edited
Loading

Closes #54.

Changes proposed in this pull request

  • Write out ng, perng, and parng files if a MAPMRI_reconstruction node in the reconstruction workflow has anisotropic_scaling set to True.
  • Write out the coeffs file.

8000
@tsalo tsalo added the bug Something isn't working label Aug 15, 2024
@tsalo tsalo mentioned this pull request Aug 15, 2024
Closed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 33.25%. Comparing base (0995156) to head (2dd0989).

Files Patch % Lines
qsirecon/interfaces/dipy.py 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   33.28%   33.25%   -0.04%     
==========================================
  Files          56       56              
  Lines        6780     6787       +7     
  Branches      888      889       +1     
==========================================
  Hits         2257     2257              
- Misses       4432     4439       +7     
  Partials       91       91

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo requested a review from mattcieslak August 15, 2024 22:18
mattcieslak
mattcieslak approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor
@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you test locally do the perng, parng, ng end up getting written out too?

@tsalo
Copy link
Member Author
tsalo commented Aug 16, 2024

I haven't tried it but I will this morning.

@tsalo tsalo changed the title Add ng, perng, and parng to Dipy MAPMRI outputs Add ng, perng, parng, and mapcoeffs to Dipy MAPMRI outputs Aug 16, 2024
@tsalo
Copy link
Member Author
tsalo commented Aug 16, 2024

I had to modify make_sloppy, but yeah they're getting written out.

@tsalo tsalo added enhancement New feature or request and removed bug Something isn't working labels Aug 16, 2024
@mattcieslak
Copy link
Contributor

All set to merge then?

@tsalo
Copy link
Member Author
tsalo commented Aug 16, 2024

Yup!

@tsalo tsalo merged commit 9f4d5fe into main Aug 16, 2024
17 checks passed
@tsalo tsalo deleted the fix-thing branch August 16, 2024 17:25
mattcieslak pushed a commit that referenced this pull request Aug 16, 2024
@tsalo @mattcieslak
Add ng, perng, parng, and mapcoeffs to Dipy MAPMRI outputs (#55)
02c61ca 
* Add ng, perng, and parng to outputs.

* Only calculate with non-aniso?

* Update dipy.py

* Update test_cli.py

* Update.

* Update dipy_mapmri_outputs.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcieslak mattcieslak mattcieslak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with Dipy MAPMRI Outputs
3 participants
@tsalo @codecov-commenter @mattcieslak
0