Add support for parsing Records via the perf_event_data crate
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title, this PR uses the
perf_event_datacrate to add support for parsingRecords gotten from a sampler. I've also replaced the implementation details of the various counter read related structs with types fromperf_event_data.The detailed changes here are
perf_event_datais now reexported as thedatamodule in the crate root. I have used#[doc(inline)]so that the docs are inlined into the main crate.GroupData,GroupEntry,GroupIter, andCounterDatahave all been replaced with types fromperf_event_data. No public API changes have been made here.Counternow keeps aParseConfigfromperf_event_datainternally instead of just aReadFormatvalue. This can now be accessed viaCounter::config. This increases the size ofCounterby 16 bytes but I don't think that that is an issue.