10000 fixed issue where the command tools wont be recognized if terminal/zs… by driff · Pull Request #661 · PlayCover/PlayCover · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fixed issue where the command tools wont be recognized if terminal/zs… #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 18, 2023

Conversation

driff
Copy link
Contributor
@driff driff commented Dec 31, 2022

Fixes an issue where you would never get that the command tools are installed if your shell had additional messages, for example, mine was showing an error when shell started because it failed to read an env file.

project file restored from develop
@zanderp25 zanderp25 requested a review from amirsaam January 8, 2023 02:47
@IsaacMarovitz
Copy link
Member

Will no longer be needed due to #711

@Depal1 Depal1 added the squash Indicates whether a PR must be squashed before being merged label Jan 18, 2023
@Depal1
Copy link
Member
Depal1 commented Jan 18, 2023

This will be merged as part of a 2.0.3 bug fix release.

@Depal1 Depal1 merged commit 23e04d0 into PlayCover:develop Jan 18, 2023
IsaacMarovitz pushed a commit to IsaacMarovitz/PlayCover that referenced this pull request Mar 11, 2023
PlayCover#661)

* fixed issue where the command tools wont be recognized if terminal/zshell outputs an additional line

* restored PlayCover.xcodeproj from develop

* restored .xcodeproj from develop

project file restored from develop

* SwiftLint and styling

Co-authored-by: Depal1 <47154119+Depal1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squash Indicates whether a PR must be squashed before being merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0