8000 Custom folder by Catta1997 · Pull Request #1816 · PlayCover/PlayCover · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Custom folder #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from
Open

Custom folder #1816

wants to merge 29 commits into from

Conversation

Catta1997
Copy link
Contributor

No description provided.

Copy link
Member
@TheMoonThatRises TheMoonThatRises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some initial feedback from a cursory glance over.

class AppFolder: ObservableObject {
static let shared = AppFolder()

@Published var folders: [Folder] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be initialized in-line.

@Catta1997
Copy link
Contributor Author

Should be all

@Catta1997 Catta1997 marked this pull request as ready for review February 14, 2025 20:32
@Catta1997 Catta1997 marked this pull request as draft March 4, 2025 07:53
- changed variable name
- added AppFolderVM
- changed save/revert changes logic
@Catta1997
Copy link
Contributor Author

I think is all

@Catta1997 Catta1997 marked this pull request as ready for review April 30, 2025 19:03
@TheMoonThatRises
Copy link
Member

There seems to be a Swiftlint error, can you take a look at that?

@Catta1997
Copy link
Contributor Author

There seems to be a Swiftlint error, can you take a look at that?

yeah, i can add another class. Let me check

@TheMoonThatRises TheMoonThatRises self-requested a review June 22, 2025 03:29
Copy link
Member
@TheMoonThatRises TheMoonThatRises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is some feedback after a bit of testing. Note that I am currently on the developer beta of MacOS Tahoe, so if any of these comments do not make any sense, please let me know.

}
ToolbarItem(placement: .primaryAction) {
Button {
addSheetApps.toggle()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am encountering a bug where if I edit the apps inside the folder, click Ok, and then switch back to the App Library, the library will be empty.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registrazione.schermo.2025-06-23.alle.09.42.27.mov

Might be a macos26 issue (or changes), seems to work (if i understand correctly)

F438
.frame(height: 40)
Picker(selection: $folder.icon, label: Text("Icon")) {
ForEach(appFolderVM.icons, id: \.self) { icon in
Image(systemName: icon)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the icons be made bigger? Same with the folder icons when creating a new folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

this bigger?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem seems that I cannot change size on a Picker, for the app List i can since is a List. Will try to change the picker to something else so i can change size

Copy link
Contributor Author
@Catta1997 Catta1997 Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@TheMoonThatRises TheMoonThatRises added enhancement New feature or request UI User interface related changes squash Indicates whether a PR must be squashed before being merged labels Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request squash Indicates whether a PR must be squashed before being merged UI User interface related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0