-
Notifications
You must be signed in to change notification settings - Fork 805
Custom folder #1816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Custom folder #1816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are some initial feedback from a cursory glance over.
PlayCover/Views/MainView.swift
Outdated
class AppFolder: ObservableObject { | ||
static let shared = AppFolder() | ||
|
||
@Published var folders: [Folder] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be initialized in-line.
Should be all |
- changed variable name - added AppFolderVM - changed save/revert changes logic
- Fix onAppear()
Need to be checked
I think is all |
There seems to be a Swiftlint error, can you take a look at that? |
yeah, i can add another class. Let me check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is some feedback after a bit of testing. Note that I am currently on the developer beta of MacOS Tahoe, so if any of these comments do not make any sense, please let me know.
} | ||
ToolbarItem(placement: .primaryAction) { | ||
Button { | ||
addSheetApps.toggle() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am encountering a bug where if I edit the apps inside the folder, click Ok
, and then switch back to the App Library
, the library will be empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Registrazione.schermo.2025-06-23.alle.09.42.27.mov
Might be a macos26 issue (or changes), seems to work (if i understand correctly)
.frame(height: 40) | ||
F438 | Picker(selection: $folder.icon, label: Text("Icon")) { | |
ForEach(appFolderVM.icons, id: \.self) { icon in | ||
Image(systemName: icon) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the icons be made bigger? Same with the folder icons when creating a new folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem seems that I cannot change size on a Picker, for the app List i can since is a List. Will try to change the picker to something else so i can change size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.