8000 fix(notes): create repository by marcin-kozinski · Pull Request #86 · Pocket/pocket-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(notes): create repository #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix(notes): create repository #86

merged 1 commit into from
Dec 12, 2024

Conversation

marcin-kozinski
Copy link
Collaborator
@marcin-kozinski marcin-kozinski commented Dec 11, 2024 •
edited
Loading

For now just an unfinished implementation of a notes repository (to be) backed with sync engine executing operations on the Graph. But setting it up with an interface allows to plug in a fake implementation with fake data. And anyway Kat is pretty much done with the backend, so I will be able to plug in real API calls real soon.

References

PR Checklist

Setup:

  • Described changes for automated release notes in PR title using
    Conventional Commits standard
  • Self Review (review, clean up, documentation)
  • Basic Self QA
  • Feature flagged as needed to ensure this specific code is beta and production ready

Review:

  • Code Review approved

@marcin-kozinski marcin-kozinski added the notes Move to "Notes" section in release notes. label Dec 11, 2024
nzeltzer
nzeltzer approved these changes Dec 11, 2024
View reviewed changes
Copy link
@nzeltzer nzeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marcin-kozinski marcin-kozinski added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 22e9734 Dec 12, 2024
4 checks passed
@marcin-kozinski marcin-kozinski deleted the notes-repository branch December 12, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzeltzer nzeltzer nzeltzer approved these changes

Assignees
No one assigned
Labels
notes Move to "Notes" section in release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcin-kozinski @nzeltzer
0