8000 Improvements and Docker by Naramsim · Pull Request #38 · PokeAPI/ditto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improvements and Docker #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2019
Merged

Improvements and Docker #38

merged 3 commits into from
Feb 2, 2019

Conversation

Naramsim
Copy link
Member
@Naramsim Naramsim commented Jan 30, 2019 •
edited
Loading

This PR brings:

@Naramsim Naramsim self-assigned this Jan 30, 2019
cmmartti
cmmartti reviewed Jan 30, 2019
View reviewed changes
pokeapi_ditto/commands/clone.py
self._crawl(res_url)
if endpoint == "pokemon":
self._crawl(res_url / "encounters")
self._crawl(URL("{}encounters/".format(res_url)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively,

self._crawl(URL(f"{res_url}encounters/"))

@Naramsim Naramsim merged commit 0c0bf08 into master Feb 2, 2019
@sargunv sargunv deleted the naramsim-patch1 branch May 10, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmmartti cmmartti cmmartti approved these changes

@tdmalone tdmalone Awaiting requested review from tdmalone

@sargunv sargunv Awaiting requested review from sargunv

Assignees

@Naramsim Naramsim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naramsim @cmmartti
0