Bug/skip name property in search #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1281 +/- ##
==========================================
+ Coverage 57.82% 57.83% +0.01%
==========================================
Files 173 173
Lines 19004 19010 +6
==========================================
+ Hits 10989 10995 +6
Misses 8015 8015
☔ View full report in Codecov by Sentry. |
shivamka1
approved these changes
Sep 25, 2023
fabianmurariu
pushed a commit
that referenced
this pull request
May 21, 2024
* add test * need to skip "name" property for now to avoid conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
put back skipping of
"name"property so IndexedGraph does not crash if it existsWhy are the changes needed?
avoid panic due to field defined multiple times
Does this PR introduce any user-facing change? If yes is this documented?
No
How was this patch tested?
added test to confirm that we can make an IndexedGraph when a vertex property
"name"is presentAre there any further changes required?
We should use prefixes to have separate name spaces for properties so we can have such a property without causing conflicts