8000 0.6.0 pre release tidy by miratepuffin · Pull Request #1308 · Pometry/Raphtory · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

0.6.0 pre release tidy #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 3, 2023
Merged

0.6.0 pre release tidy #1308

merged 14 commits into from
Oct 3, 2023

Conversation

miratepuffin
Copy link
Collaborator
@miratepuffin miratepuffin commented Sep 29, 2023 •
edited
Loading

What changes were proposed in this pull request?

  • We forgot to '@Getter' the edges function, so this has been added and the docs/tests updated.
  • The arguments for the pandas loaders functions have been standardised
  • Standardised window arguments to start and end
  • Added proper parsing error message for into_time
  • Added a test to ensure saving to bincode throws an error if the dir doesn't exist
  • Split pandas tests into seperate file

Why are the changes needed?

Mixture of requests from users and internal team for QOL fixes before minor release.

Does this PR introduce any user-facing change? If yes is this documented?

Yes, all documented.

How was this patch tested?

Existing tests + new ones where required.

Issues

Fixes #1276
Fixes #1270
Fixes #1261
Fixes #1177

Are there any further changes required?

@codecov
Copy link
codecov bot commented Sep 29, 2023 •
edited
Loading

Codecov Report

Attention: 123 lines in your changes are missing coverage. Please review.

Comparison is base (293ba7c) 57.12% compared to head (f4a09b3) 57.14%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1308      +/-   ##
==========================================
+ Coverage   57.12%   57.14%   +0.01%     
==========================================
  Files         179      179              
  Lines       19624    19614      -10     
==========================================
- Hits        11210    11208       -2     
+ Misses       8414     8406       -8
Files Coverage Δ
raphtory-graphql/src/model/filters/node_filter.rs 0.00% <ø> (ø)
raphtory/src/core/entities/properties/props.rs 83.19% <100.00%> (ø)
raphtory/src/db/api/view/edge.rs 82.25% <ø> (ø)
raphtory/src/db/api/view/graph.rs 97.35% <100.00%> (ø)
raphtory/src/db/api/view/time.rs 82.16% <ø> (ø)
raphtory/src/db/graph/edge.rs 69.35% <100.00%> (ø)
raphtory/src/db/graph/vertex.rs 72.34% <100.00%> (ø)
raphtory/src/db/task/edge/eval_edge.rs 98.33% <ø> (ø)
raphtory/src/db/task/edge/window_eval_edge.rs 100.00% <100.00%> (ø)
raphtory/src/db/task/vertex/eval_vertex.rs 98.75% <100.00%> (ø)
... and 15 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miratepuffin miratepuffin force-pushed the features/0.6.0-cleanup branch from 976571f to b6fd3da Compare October 2, 2023 15:14
@miratepuffin miratepuffin changed the title We forget to getter edges 0.6.0 pre release tidy Oct 2, 2023
@miratepuffin miratepuffin merged commit f556951 into master Oct 3, 2023
@miratepuffin miratepuffin deleted the features/0.6.0-cleanup branch October 3, 2023 08:53
fabianmurariu pushed a commit that referenced this pull request May 21, 2024
@miratepuffin
0.6.0 pre release tidy (#1308)
3657da2 
* We forget to getter edges

* forgot notebook tests

* standardised load from pandas arg names

* fmt

* fix fake pandas test

* fix test

* standardise window arguments

* fix test

* fmt

* fully remove t_start/t_end

* fmt

* Added a test to make sure #1177 works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haaroon Haaroon Haaroon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@miratepuffin @Haaroon
0