Add expansion filters #1387
Merged
Add expansion filters #1387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miratepuffin
approved these changes
Nov 21, 2023
fabianmurariu
pushed a commit
that referenced
this pull request
May 21, 2024
* add new functions to expand using only nodes or edges * add logs to vectorizing * fix bug on split_text_with_constant_size() * fix compilation error * remove some printlines * add verbose paramer to vectorise * remove comments * small fixes inside split_text_by_line_breaks * Remove ScoredDocument struct * fix bug in expansion filters and add test * remove comments from python tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Two new function were added to VectorisedGraph:
expand_nodes_by_similarityexpand_edge_by_similarityThis PR also fixes a bug in the function
split_text_with_constant_sizeWhy are the changes needed?
These are needed for cases were users want to carry out an expansion but they want to travel through only onw type of entities.
Does this PR introduce any user-facing change? If yes is this documented?
Yes. It is not documented because the documentation for the vectors module is still a pending task to be addressed as a batch.
How was this patch tested?
A new python test was added for these two new functions
Issues
Are there any further changes required?
No