Merge branch 'main' into feat/mobile-surveys-merge-main #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: xcframework builds * fix: import access level * feat: add sample xcframework project * fix: build examples * chore: update CHANGELOG
* chore: skip creating a visionOS simulator if not needed * fix: external sdk example
# Conflicts: # CHANGELOG.md # Makefile # PostHog.podspec # PostHog.xcodeproj/project.pbxproj # PostHog/PostHogApi.swift # PostHog/PostHogSDK.swift # PostHog/PostHogVersion.swift # PostHogTests/PostHogFeatureFlagsTest.swift # PostHogTests/PostHogSessionManagerTest.swift # PostHogTests/TestUtils/MockApplicationLifecyclePublisher.swift # PostHogTests/TestUtils/TestPostHog.swift
marandaneto
approved these changes
Mar 5, 2025
|
A test seems to be failing but runs greek locally. Will merge for now though and address this on next PR if it's still an issue |
ioannisj
added a commit
that referenced
this pull request
Apr 9, 2025
* feat: load remote config and feature flags (#283) * feat: load remote config and feature flags * fix: cleanup * fix: redundant assignment * fix: hasFeatureFlags * fix: lint * feat: add survey domain models (#284) * feat: add survey domain models * fix: reuse date formatter * fix: improve test fixtures and model consistency * Merge branch 'main' into feat/mobile-surveys-merge-main (#313) * chore: session replay ga (#286) * fix: xcframework builds (#288) * fix: xcframework builds * fix: import access level * feat: add sample xcframework project * fix: build examples * chore: update CHANGELOG * Update version * chore: skip creating a visionOS simulator if not needed (#289) * chore: skip creating a visionOS simulator if not needed * fix: external sdk example * Update version * feat: add survey domain models * Merge branch 'main' into feat/mobile-surveys-merge-main # Conflicts: # CHANGELOG.md # Makefile # PostHog.podspec # PostHog.xcodeproj/project.pbxproj # PostHog/PostHogApi.swift # PostHog/PostHogSDK.swift # PostHog/PostHogVersion.swift # PostHogTests/PostHogFeatureFlagsTest.swift # PostHogTests/PostHogSessionManagerTest.swift # PostHogTests/TestUtils/MockApplicationLifecyclePublisher.swift # PostHogTests/TestUtils/TestPostHog.swift * fix: lint * feat: add base survey integration (#314) * feat: add survey domain models * Merge branch 'main' into feat/mobile-surveys-merge-main # Conflicts: # CHANGELOG.md # Makefile # PostHog.podspec # PostHog.xcodeproj/project.pbxproj # PostHog/PostHogApi.swift # PostHog/PostHogSDK.swift # PostHog/PostHogVersion.swift # PostHogTests/PostHogFeatureFlagsTest.swift # PostHogTests/PostHogSessionManagerTest.swift # PostHogTests/TestUtils/MockApplicationLifecyclePublisher.swift # PostHogTests/TestUtils/TestPostHog.swift * feat: base surveys integration * feat: base survey display * fix: builds * fix: test * fix: tests * fix: remote config tests * feat: add survey UI and display logic (#320) * feat: add survey domain models * Merge branch 'main' into feat/mobile-surveys-merge-main # Conflicts: # CHANGELOG.md # Makefile # PostHog.podspec # PostHog.xcodeproj/project.pbxproj # PostHog/PostHogApi.swift # PostHog/PostHogSDK.swift # PostHog/PostHogVersion.swift # PostHogTests/PostHogFeatureFlagsTest.swift # PostHogTests/PostHogSessionManagerTest.swift # PostHogTests/TestUtils/MockApplicationLifecyclePublisher.swift # PostHogTests/TestUtils/TestPostHog.swift * feat: base surveys integration * feat: base survey display * fix: builds * fix: test * fix: tests * fix: remote config tests * feat: add survey ui components * feat: survey question type display and next question logic * feat: send survey seen, sent, dismissed events * feat: add event-activated surveys * fix: empty question description * fix: hit test on iOS 18 * fix: safe area inset * refactor: move display related to logic to display manager * fix: handle case displayThankYouMessage is false * fix: tests * fix: handle optional questions * fix: build * feat: public api * chore: update CHANGELOG * feat: iOS15 presentation detents (#324) * feat: add survey domain models * Merge branch 'main' into feat/mobile-surveys-merge-main # Conflicts: # CHANGELOG.md # Makefile # PostHog.podspec # PostHog.xcodeproj/project.pbxproj # PostHog/PostHogApi.swift # PostHog/PostHogSDK.swift # PostHog/PostHogVersion.swift # PostHogTests/PostHogFeatureFlagsTest.swift # PostHogTests/PostHogSessionManagerTest.swift # PostHogTests/TestUtils/MockApplicationLifecyclePublisher.swift # PostHogTests/TestUtils/TestPostHog.swift * feat: base surveys integration * feat: base survey display * fix: builds * fix: test * fix: tests * fix: remote config tests * feat: add survey ui components * feat: survey question type display and next question logic * feat: send survey seen, sent, dismissed events * feat: add event-activated surveys * fix: empty question description * fix: hit test on iOS 18 * fix: safe area inset * refactor: move display related to logic to display manager * fix: handle case displayThankYouMessage is false * fix: tests * feat: add backport for iOS 15 presentation detents * fix: lint * fix: sheet height * fix: remove ViewBuilder attribute * feat: add configuration option for remoteConfig * chore: prefix survey models * fix: cache needed integrations in sdk instance * chore: split survey models to multiple files * chore: refactor remote config callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Just bringing over latest changes from
maininto this feature branch. A number of conflicts so worth a look#skip-changelog
Conflicts:
💚 How did you test it?
📝 Checklist