fix: add field to proxy client setup #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
This PR adds the log_captured_exceptions option to the proxy client setup in the PostHog Python SDK.
- Added missing
log_captured_exceptionsparameter to the Client initialization in_proxy()function inposthog/__init__.py - Updated version from 3.24.0 to 3.24.1 in
posthog/version.pyto reflect this bugfix - Added changelog entry for version 3.24.1 documenting the addition of this option to proxy setup
- Fixes an oversight from PR feat: log captured exceptions #215 which added the feature but missed including it in the proxy pattern implementation
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
hpouillot
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #215. Just forgot to add the extra config when calling as a singleton