chore: Make condition_index optional. Also added some scripts for local dev.
#223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See PostHog/meta#309 for the rationale behind these scripts.
This is part of PostHog/posthog#30569
There was a problem hiding this comment.
PR Summary
This PR adds development scripts and makes condition_index optional in feature flag responses for the PostHog Python client.
- Modified
FlagReasonclass inposthog/types.pyto makecondition_indexanOptional[int]instead of requiring an integer value - Added
bin/setupscript to create virtualenv and install dev/test dependencies - Added
bin/fmtscript for code formatting using black and isort - Added
bin/buildscript for running flake8 and mypy checks - Added
bin/testscript for running pytest with helper utilities frombin/helpers/_utils.sh
7 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
| source bin/helpers/_utils.sh | ||
| set_source_and_root_dir | ||
|
|
||
| flake8 posthog --ignore E501,W503 |
There was a problem hiding this comment.
style: Consider adding --config=setup.cfg to ensure flake8 uses consistent configuration across different environments
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PostHog/posthog#30569 for why I'm making this change to
condition_index.See PostHog/meta#309 for the rationale behind these scripts.