chore: Release automatically when changed version.py #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pushing to master, we now automatically release a new version if we detect a change to `version.py`
There was a problem hiding this comment.
PR Summary
This PR automates the release process by triggering the release workflow whenever version.py is modified in the master branch, streamlining package publishing.
- Added
pushtrigger in/.github/workflows/release.yamlto watch for changes toposthog/version.pyon master branch - Uses
POSTHOG_BOT_GITHUB_TOKENsecret for authentication and release creation - Workflow detects version from
version.pyand uses it for both PyPI and GitHub releases - Maintains manual
workflow_dispatchtrigger as fallback option
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+34
to
+35
| - name: Push release to PyPI | ||
| run: make release && make release_analytics |
There was a problem hiding this comment.
style: Release commands could fail independently. Consider splitting into separate steps for better error visibility.
daibhin
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pushing to master, we now automatically release a new version if we detect a change to
version.py