-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Google Ads destination #27712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
You can now use the Google Ads destination using this link: https://us.posthog.com/pipeline/new/destination/hog-template-google-ads Please share feedback or issues you encounter. |
Hi @MarconLP . I am trying to use this feature. When linking my Google Ads account, I get an error claiming that I'm missing an OAuth scope. (I can't find the exact error message anymore). While the integration still succeeds, when trying to select a customer id, etc. I get a bunch of 500 errors. |
Hey @slimy-pufflefish, I wasn't able to replicate the issue. Are you re-using the old google ad destination? Could you share your projectId? Did that error disappear after re-linking the google ads account? |
I am clicking "Choose Google Ads Connection" -> "Connect to Google Ads". I did not have a Google Ads integration prior to today. I tried deleting my integration and re-adding it. That did not help. My Posthog project URL is: https://us.posthog.com/project/110483/. After doing the connection -- it says the integration was successful, but then gives
|
same here in eu posthog (https://eu.posthog.com/project/13059): |
Hey, it seems like the API request is failing with the following error |
That was the issue. We'll now ignore all accounts that are canceled or haven't been fully setup. The fix should be live in around 30 minutes. |
wuuuuu, thank you so much! |
We have multiple accounts, and the pipeline raises |
Hi guys, I am trying to set this up but am running into the following issue. When targetting an existing conversion action I am getting: I don't know how to create a conversion action from scratch to target from posthog, as it remains inactive in google ads until I add a Data Source. Any help would be greatly appreciated :) |
Hey @leng-yue, it seems like you are trying to import a |
Hey @davidtopf, you'll need to create conversion goals as specified in this guide and setup the destination inside of PostHog. Note that it might take up to several days for Google to update the status to from |
@MarconLP thank you so much for the quick reply! The guide is a little outdated, in that the flow described in it no longer exists, at least in my google ads account. However, I think the gist of it is the same and if I get you correctly it's time that will get a conversion action to switch from inactive to active. I have added a conversion action called ""New Subscription." - Posthog Event" with an offline data source marked as "Event to be set up later" and am now just going to wait a couple of date for the status to change (see pictures) rather than clicking on "Set up import" in the Actions column. |
Thank you for the heads up! Will get that updated ASAP.
Correct, assuming the Google ads destination isn't throwing any errors. |
Correct - You do not need to set up filters, as we skip events without a valid
|
Hi @MarconLP, I set this up and it works when I run a test, but I get this error: Here you can see it working: |
Hey, we've had an issue migrating our environment variables to a new system, which caused issues with some of our OAuth integrations. The issue should have been resolved by now. Let me know if you are still experiencing issues. |
@MarconLP I am still experiencing this issue and can not send a single request: Error executing function on event 01951508-4ab5-7a7d-bee8-e17f90de28e3: Error('Error from googleads.googleapis.com (status 401): {\'error\': {\'code\': 401, \'message\': \'Request had invalid authentication credentials. Expected OAuth 2 access token, login cookie or other valid authentication credential. See https://developers.google.com/identity/sign-in/web/devconsole-project.\', \'status\': \'UNAUTHENTICATED\'}}') -- |
Facing the same issue above |
@davidtopf @ThibeauMaerevoet are you still seeing the issue? We had a bug but we fixed it earlier this week so the invalid authentication credentials should have gone away by now. |
Hey. The issue was still present at the time of my comment. I'm not sure
now. We disabled the ads as we awaited an update
…On Fri, Feb 21, 2025, 12:58 PM Paweł Ledwoń ***@***.***> wrote:
@davidtopf <https://github.com/davidtopf> @ThibeauMaerevoet
<https://github.com/ThibeauMaerevoet> are you still seeing the issue? We
had a bug but we fixed it earlier this week so the invalid authentication
credentials should have gone away by now.
—
Reply to this email directly, view it on GitHub
<#27712 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDBTCAPKJTPURJKHK7JSBBD2Q4IGJAVCNFSM6AAAAABVR6CV5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZUGM3DEOJUHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: pl]*pl* left a comment (PostHog/posthog#27712)
<#27712 (comment)>
@davidtopf <https://github.com/davidtopf> @ThibeauMaerevoet
<https://github.com/ThibeauMaerevoet> are you still seeing the issue? We
had a bug but we fixed it earlier this week so the invalid authentication
credentials should have gone away by now.
—
Reply to this email directly, view it on GitHub
<#27712 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDBTCAPKJTPURJKHK7JSBBD2Q4IGJAVCNFSM6AAAAABVR6CV5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZUGM3DEOJUHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@pl I have not been experiencing the issue anymore! I've not had issues since sometime on the 18th I think. All calls on the 19th went through and some on 18th failed |
Great, thanks for confirming. @ThibeauMaerevoet feel free to reenable the destination as the bug is fixed. |
Yep. Seems to be working now.
…On Mon, Feb 24, 2025, 9:45 AM Paweł Ledwoń ***@***.***> wrote:
Great, thanks for confirming.
@ThibeauMaerevoet <https://github.com/ThibeauMaerevoet> feel free to
reenable the destination as the bug is fixed.
—
Reply to this email directly, view it on GitHub
<#27712 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDBTCAMBVXI6KT2SSK2OEML2RLL4FAVCNFSM6AAAAABVR6CV5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZXG42TCOJYHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: pl]*pl* left a comment (PostHog/posthog#27712)
<#27712 (comment)>
Great, thanks for confirming.
@ThibeauMaerevoet <https://github.com/ThibeauMaerevoet> feel free to
reenable the destination as the bug is fixed.
—
Reply to this email directly, view it on GitHub
<#27712 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDBTCAMBVXI6KT2SSK2OEML2RLL4FAVCNFSM6AAAAABVR6CV5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZXG42TCOJYHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @pl & @MarconLP Two things I noticed: Outdated Docs
Error
The invalid argument looks like this in the source code:
It looks like my input.customerId is x...x/x...x - could it be the case that splitByString is using an array indexing that starts at 0? |
Hey @lksrpp, thank you for the feedback. I wasn't able to replicate the issue. Could you share your project/environment ID? |
This issue has 2156 words at 29 comments. Issues this long are hard to read or contribute to, and tend to take very long to reach a conclusion. Instead, why not:
Is this issue intended to be sprawling? Consider adding label |
@MarconLP, sure.
Reproduction Steps:
|
Hey @lksrpp, it looks like you managed to update the template but weren't required to re-select the It looks like you have another error:
Can you confirm that the conversion goal is located within the same account that is running the campaign? |
Hey @MarconLP , thanks for your feedback!
I'm not sure if I understand this correctly, sorry for the confusion. If I create a new destination from the updated template, and I select my Google Ads Account in the customer id field, it is very briefly shown as "0123456789/0123456789" before it resolves to its actual name. Wouldn't this still throw an error for
Yes. In this case, we have secondary Google Ads account that was sending users in as well; these conversion events were throwing the error. I updated the matching event to exclude the utm_campaign from the other Ads Account. The primary account works correctly with the configured destination. I can see the correct conversions in the Google Ads UI. |
No, our arrays are 1-indexed. So |
Might want to add a note to your docs:
|
Good point! Added details around google's processing times. |
We have integrated conversion actions, but in the logs we see this message:
Should we do something, or will Posthog automatically push this event again to Google Ads? |
We won't automatically retry failed requests, but you can wait 6 hours and use the testing tab to retry several events at once. |
Hey @bernhardklug, can you check the logs of those invocations? An event that has been filtered out because the gclid is missing will be considered |
Just had Google error during ingestion because the distinctId of the event is flagged as PII. Anyone else have this? If I comment out the orderId it works. |
Could you share a screenshot of the error? |
Hey, thank you for sharing those details. Looks like you are using an email as the distinct_id, so you'll need to hash it before using it as the order_id. You can do this using the following expression: I would recommend that you switch over to using |
Oh I feel stupid now. Thank you. |
The weird thing is, in Google, it only shows three conversions – even though it said five were successful. One of them had the Google Click ID, but somehow the others didn’t. I don’t really understand why, but let’s count that one as valid. Still, a few conversions are missing, and I’m not sure why. I’ve now set up a second version to test, and the new one seems to work better. But the old setup… in the last 30 days, it only recorded a few conversions, even though Posthog shows many more as successful. Still trying to figure out what’s going wrong there. |
@MarconLP A user raised a concern about the timestamps
|
Hey - we hardcoded the timezone to If I capture an event at 10:30 in the UTC+2 timestamp. The conversion date will evaluate to We've managed to reduce the error rate for
You can add or remove days to the timestamp by using the following input expression:
|
@bernhardklug - we have the same issue, and the conversions stopped exactly on May 1st, and we cannot get them working again. We get this response from Google Ads Conv API, which LOOKS like a success, but the conversion never appears.
We tried temporarily disabling enhanced conversions (completely) but it made no difference. If we delete/recreate the conversion, we'll disrupt our machine bid model - a pretty big deal for us. I would be thrilled to hear of any fixes you found? Or even any novel diagnostics / debugging you thought up? |
Note: I discovered that Google Ads API v16 was sunsetted on May 1st - exatctly when we lost the connection. Google API team contact tells me the logged API response above was insufficient and incomplete, so cannot help me. I did submit a ticket to Posthog support out of desperation. |
Uh oh!
There was an error while loading. Please reload this page.
Feature request
We've merged our Google Ads destination and are doing some additional testing.
TODOs:
ADWORDS_DEVELOPER_TOKEN
env variable (slack)GOOGLE_ADS_APP_CLIENT_ID
&GOOGLE_ADS_APP_CLIENT_SECRET
GOOGLE_ADS_DEVELOPER_TOKEN
Roadmap items:
gbraid
orwbraid
parameters in addition to thegclid
propertyorder_id
cc: @benjackwhite
related: PostHog/posthog.com#10396
The text was updated successfully, but these errors were encountered: