8000 feat(web-analytics): Add url, pathname and host to custom channel definitions by robbie-c · Pull Request #27226 · PostHog/posthog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(web-analytics): Add url, pathname and host to custom channel definitions #27226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 6, 2025
Merged

feat(web-analytics): Add url, pathname and host to custom channel definitions #27226

merged 10 commits into from
Jan 6, 2025

Conversation

robbie-c
Copy link
Member
@robbie-c robbie-c commented Jan 2, 2025 •
edited
Loading

Problem

A user recently asked to be able to make custom channel types based on pathname or query parameters

Changes

Add the full initial URL, pathname, and host, to custom channel definitons

As a drive-by I added this button here to make it more visible that you can change these:
Screenshot 2025-01-02 at 18 10 00

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Added some extra tests around custom channel types

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 2, 2025 •
edited
Loading

Size Change: 0 B

Total Size: 9.44 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 9.44 MB

compressed-size-action

@robbie-c robbie-c force-pushed the feat/add-pathname-to-custom-channel-definitions branch from 3602e21 to 6f79567 Compare January 2, 2025 17:44
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@robbie-c robbie-c force-pushed the feat/add-pathname-to-custom-channel-definitions branch from 7a31d76 to 80e6fd5 Compare January 3, 2025 13:33
rafaeelaudibert
rafaeelaudibert requested changes Jan 6, 2025
View reviewed changes
@robbie-c robbie-c force-pushed the feat/add-pathname-to-custom-channel-definitions branch from 80e6fd5 to 8feee84 Compare January 6, 2025 15:17
@robbie-c robbie-c force-pushed the feat/add-pathname-to-custom-channel-definitions branch from 0351394 to f6530b5 Compare January 6, 2025 15:24
@robbie-c robbie-c enabled auto-merge (squash) January 6, 2025 15:24
@robbie-c robbie-c merged commit 7357424 into master Jan 6, 2025
99 checks passed
@robbie-c robbie-c deleted the feat/add-pathname-to-custom-channel-definitions branch January 6, 2025 16:55
@robbie-c robbie-c mentioned this pull request Jan 8, 2025
Closed
@robbie-c robbie-c mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeelaudibert rafaeelaudibert rafaeelaudibert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robbie-c @posthog-bot @rafaeelaudibert
0