feat: Allow directly creating dashboard template from table #30855
Conversation
There was a problem hiding this comment.
PR Summary
This change updates the DashboardTemplatesTable component to enable direct dashboard creation by making the template name a clickable link. It streamlines the user experience by integrating newDashboardLogic for creating dashboards without extra clicks.
- Updated
/frontend/src/scenes/dashboard/dashboards/templates/DashboardTemplatesTable.tsxto render template names as clickable LemonTableLink components. - Invokes createDashboardFromTemplate with appropriate template details and variables.
- Integrates seamlessly with newDashboardLogic while preserving permissions and existing state management.
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
Bumping to keep from closing |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Allow users to create new dashboard template direct from table, not just the
Newmodal, which can take more clicks.This is a UX suggestion - since it was so small I didn't raise an Issue first, so feel free to close if it doesn't fit with ya'lls product goals.
Problem
As a user of Posthog, I was confused when I wasn't able to interact and create a new Dashboard directly from a template in the list - I had to first decide which one I liked, and then open up the
New Dashboardmodal, search for the one I wanted, and then click it. There was more friction than I had hoped.My ideal flow as a user would be:
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Updated the table of Dashboard template options so that the name is a clickable button (which creates a new dashboard with that template, same as choosing from modal) rather than just text string.
Does this work well for both Cloud and self-hosted?
How did you test this code?
Developing Locallydoc might be out of date, becausepnpm test:unitdoesn't seem to be a valid command - or my setup is wonky. Went with what I hoped was close to same level of coverage: