refactor: Update postgres-docker image to 15.12 #31525
Conversation
There was a problem hiding this comment.
PR Summary
This PR updates PostgreSQL from version 12 to 15.12 across Docker Compose configurations and increases the DigitalOcean droplet size for hobby deployments.
- Inconsistent comment in
docker-compose.hobby.ymlmentions pinning to Postgres 12 but uses 15.12-alpine image - Missing migration path/pg_upgrade process for existing hobby deployments moving from Postgres 12 to 15
- Added
docker-compose.base.ymlto E2E test triggers in CI workflow for better coverage - Doubled DigitalOcean droplet resources to 8vCPU/16GB for hobby deployment testing
- Breaking changes between Postgres 12 and 15 need to be addressed for self-hosted installations
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| # Pin to postgres 12 until we have a process for pg_upgrade to postgres 15 for exsisting installations | ||
| image: ${DOCKER_REGISTRY_PREFIX:-}postgres:12-alpine | ||
| image: ${DOCKER_REGISTRY_PREFIX:-}postgres:15.12-alpine |
There was a problem hiding this comment.
logic: Comment states 'Pin to postgres 12' but image is set to 15.12. Either update the comment or keep postgres 12 as indicated
| # Pin to postgres 12 until we have a process for pg_upgrade to postgres 15 for exsisting installations | |
| image: ${DOCKER_REGISTRY_PREFIX:-}postgres:12-alpine | |
| image: ${DOCKER_REGISTRY_PREFIX:-}postgres:15.12-alpine | |
| # Using postgres 15.12 for new installations | |
| image: ${DOCKER_REGISTRY_PREFIX:-}postgres:15.12-alpine |
|
Size Change: +81 B (0%) Total Size: 13.7 MB ℹ️ View Unchanged
|
| # Pin to postgres 12 until we have a process for pg_upgrade to postgres 15 for exsisting installations | ||
| image: ${DOCKER_REGISTRY_PREFIX:-}postgres:12-alpine | ||
| image: ${DOCKER_REGISTRY_PREFIX:-}postgres:15.12-alpine |
There was a problem hiding this comment.
There appears to be a contradiction between the comment and the actual code change. The comment states:
Pin to postgres 12 until we have a process for pg_upgrade to postgres 15 for existing installations
However, the image is being updated to postgres:15.12-alpine. This raises concerns about backward compatibility for existing hobby installations, as PostgreSQL 15 data directories are not compatible with PostgreSQL 12.
Before proceeding with this change, it would be important to:
- Either update the comment to reflect the current state
- Or maintain PostgreSQL 12 until a proper upgrade process is implemented
- Or document the upgrade process if one exists
Without addressing this inconsistency, existing hobby installations may experience failures during upgrades due to PostgreSQL version incompatibility.
| # Pin to postgres 12 until we have a process for pg_upgrade to postgres 15 for exsisting installations | |
| image: ${DOCKER_REGISTRY_PREFIX:-}postgres:12-alpine | |
| image: ${DOCKER_REGISTRY_PREFIX:-}postgres:15.12-alpine | |
| # Using postgres 15 - Note: Upgrading from postgres 12 requires a data migration process | |
| image: ${DOCKER_REGISTRY_PREFIX:-}postgres:15.12-alpine |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Important
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Problem
Changes
Does this work well for both Cloud and self-hosted?
How did you test this code?