8000 fix: Remove non-existent path by rafaeelaudibert · Pull Request #31529 · PostHog/posthog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Remove non-existent path #31529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Conversation

rafaeelaudibert
Copy link
Member

We dont have anything in these paths, but storybook cant run locally if this is selected, let's just remove it. It's probably related to us running stuff from inside node_modules incorrectly

We dont have anything in these paths, but storybook cant run locally if this is selected, let's just remove it. It's probably related to us running stuff from inside `node_modules` incorrectly
@rafaeelaudibert
Copy link
Member Author

@adamleithp I need to remove this to get Storybook to work 😢, can you check?

@rafaeelaudibert rafaeelaudibert enabled auto-merge (squash) April 23, 2025 19:27
Copy link
Contributor
@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Removed an unused path from Tailwind CSS configuration to fix local Storybook development issues.

  • Removed path ../../common/**/frontend/**/*.{ts,tsx} from common/tailwind/tailwind.config.js content configuration as it was causing Storybook to fail locally and wasn't being used

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@adamleithp
Copy link
Contributor

@adamleithp I need to remove this to get Storybook to work 😢, can you check?

Hey, checked, but I'm wary of this's breaking something @mariusandra is planning

@rafaeelaudibert rafaeelaudibert merged commit b25e219 into master Apr 23, 2025
92 checks passed
@rafaeelaudibert rafaeelaudibert deleted the remove-other-tailwind-config branch April 23, 2025 19:33
@rafaeelaudibert
Copy link
Member Author

Ill pay you a tequila in Mexico if this breaks something before the offsite @mariusandra

@mariusandra
Copy link
Collaborator

Ill pay you a tequila in Mexico if this breaks something before the offsite @mariusandra

Deal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0