feat(schema): add backend side migrations for query schema #31554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # frontend/src/queries/schema.json # posthog/schema.py
95dce02 to
655b0c1
Compare
There was a problem hiding this comment.
PR Summary
Major UI and feature enhancements across file system management and navigation, along with infrastructure improvements for project organization and quota management.
- Added new MoveTo and PinnedFolder components with complete file system management capabilities in
frontend/src/lib/components/MoveTo/MoveTo.tsxand related files - Introduced quota limiting improvements in
ee/billing/quota_limiting.pywith region-specific monitoring and better error handling - Enhanced session recording analysis in
ee/session_recordings/session_summary/with granular error categorization (abandonment, confusion, exceptions) - Implemented pre-aggregated web analytics with new Dagster assets in
dags/web_preaggregated_internal.pyfor efficient data processing - Refactored project tree navigation with new protocol-based file system (
project://) and expanded panel types infrontend/src/layout/panel-layout/
113 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
# Conflicts: # posthog/hogql_queries/legacy_compatibility/filter_to_query.py # posthog/schema.py # posthog/tasks/exports/image_exporter.py
# Conflicts: # frontend/src/queries/schema.json # posthog/schema.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://github.com/PostHog/meta/blob/query-migrations/requests-for-comments/2025-02-25-query-migrations.md
Changes
versionfield to each query nodeSchemaMigrationclass, that bumps the version of a node and applies the upgrade given by the migration subclassconversion_to_query_basedcontext manager with the new context manager that also upgrade queries. this should cover all places where we read an insight's query.to_representation).calculate_trends_hogqlandcalculate_funnel_hogqlendpoints.queryandendpoints andquery_awaitedprocess_query_dict.retentionFilter.showMean->retentionFilter.meanRetentionCalculationHow did you test this code?
Added tests and manual testing