fix: even less more slow for persistence task #31657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Increased rate limit for session recording persistence tasks from 15/min to 30/min to help process a large backlog of 55k tasks accumulated over the weekend.
- Modified
ee/session_recordings/persistence_tasks.pyto double the rate limit for bothpersist_single_recordingandpersist_single_recording_v2tasks - Tasks are monitored via Prometheus counters
REPLAY_NEEDS_PERSISTENCE_COUNTERandREPLAY_NEEDS_PERSISTENCE_V2_COUNTER - Tasks run in dedicated
SESSION_REPLAY_PERSISTENCECelery queue for isolation
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
veryayskiy
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we just can't get through the persistence task now it has rate limiting applied.
there are still 55k tasks to process from the weekend