chore(persons): Refactor person properties update code so it can be reused #33368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Refactored person properties update logic by moving it into a dedicated directory structure and extracting update functionality for reusability in batch processing.
- Moved
person-state.tstoplugin-server/src/worker/ingestion/persons/and split property update logic into newperson-update.tsfile - Added
personPropertyKeyUpdateCounterinmetrics.tsto track property updates with proper Prometheus instrumentation - Updated all import paths from
../person-stateto../persons/person-stateacross multiple files - Maintained thorough test coverage by extending
person-state.test.tswith JSONB optimization flag compatibility tests - Renamed parameter
distinctIdBatchStoretopersonStoreBatchfor better clarity in function signatures
6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
112
to
113
| }) | ||
| }) |
There was a problem hiding this comment.
There appears to be an extra closing bracket }) on line 113 that doesn't correspond to any opening bracket. This will cause a syntax error when the code is executed. Please remove this redundant bracket to ensure the code compiles correctly.
Suggested change
| }) | |
| }) | |
| }) |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
8624b1f to
7ebb096
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Problem
This refactor moves the
person-state.tsfile into persons as well as moving all of the update logic into its own separate file so we can reuse this code when making the changes for batch writing.Changes
Did you write or update any docs for this change?
How did you test this code?