feat: service name filter #33436
feat: service name filter #33436
Conversation
There was a problem hiding this comment.
PR Summary
Implements service-based filtering for logs by restructuring taxonomic filters and adding service name properties across the application.
- Renamed taxonomic filter group from
LogstoLogAttributesin multiple files includingtypes.tsandschema.pyfor more precise attribute filtering - Added new
serviceNames: list[str]field toLogsQuerymodel for service filtering support - Introduced new 'service_name' property in
taxonomy.pycore filter definitions for logs group - Added
initialLoadprop toPropertyValuecomponent to support proactive loading of service names - Updated property filter type mappings and universal filters logic to accommodate the new log attribute filtering structure
11 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
| useEffect(() => { | ||
| if (initialLoad) { | ||
| load('') | ||
| } | ||
| }, []) |
There was a problem hiding this comment.
logic: This useEffect's dependency array is empty but uses initialLoad from props. Add initialLoad to the dependency array to prevent stale closures.
| useEffect(() => { | |
| if (initialLoad) { | |
| load('') | |
| } | |
| }, []) | |
| useEffect(() => { | |
| if (initialLoad) { | |
| load('') | |
| } | |
| }, [initialLoad]) |
posthog/taxonomy/taxonomy.py
Outdated
| "logs": { | ||
| "service_name": { | ||
| "label": "Service name", | ||
| "description": "The service that emitted the log", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
style: Consider defining the type field as 'String' to maintain consistency with other filter definitions
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
5d564d9 to
f39770f
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
We want to be able to filter logs but service
Changes
Add a top level property filter