fix(bigquery-dwh): Get correct primary keys from BigQuery #33526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Fixed BigQuery data warehouse integration to correctly retrieve primary key column names by querying KEY_COLUMN_USAGE instead of relying on TABLE_CONSTRAINTS.constraint_name field.
- Modified
get_primary_keysinposthog/temporal/data_imports/pipelines/bigquery/source.pyto use KEY_COLUMN_USAGE for accurate primary key column identification - Fixed critical issue where
constraint_namefield incorrectly returns 'pk$' instead of actual column names - Important data integrity fix ensuring proper table relationships and constraints in BigQuery integration
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Gilbert09
approved these changes
Jun 11, 2025
5234721 to
aabb8a2
Compare
The field `constraint_name` from TABLE_CONSTRAINTS is not the column name when the constraint is a primary key (it's `pk$` in that case). This queries KEY_COLUMN_USAGE instead to actually get the primary key column name.
aabb8a2 to
e6fd6f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Problem
The field
constraint_namefrom TABLE_CONSTRAINTS is not the column name when the constraint is a primary key (it's calledpk$in that case). This means folks with primary key fields that are notidcannot incrementally sync.Changes
This queries KEY_COLUMN_USAGE instead to actually get the primary key column name.
Did you write or update any docs for this change?
How did you test this code?