fix: fix flaky test #33539
Merged
fix: fix flaky test #33539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Modified test case in ee/clickhouse/models/test/test_cohort.py to make it more resilient against non-deterministic database result ordering.
- Updated
test_cohortpeople_with_not_in_cohort_operator_and_no_precalculationto useassertCountEqualinstead of relying on specific result ordering - Replaced direct array index assertions with set-based validation to handle variable result ordering from the database
- Improves test reliability while maintaining the same functional coverage
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
sortafreel
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Problem
Changes
Did you write or update any docs for this change?
How did you test this code?