fix: lemon tabs data attrs #33532
Merged
fix: lemon tabs data attrs #33532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Enhanced type safety and data attribute support in LemonTabs component to improve analytics tracking capabilities.
- Added
data-attrprop toAbstractLemonTabinterface allowing per-tab attribute tracking - Implemented proper data-attr application on individual tab button elements in
frontend/src/lib/lemon-ui/LemonTabs/LemonTabs.tsx - Added TypeScript type safety in
frontend/src/scenes/session-recordings/filters/RecordingsUniversalFiltersEmbed.tsxby explicitly typing tabs asLemonTab<string>[]
2 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
|
Size Change: +27 B (0%) Total Size: 1.83 MB
|
veryayskiy
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we hadn't typed our tabs, so I added data-attrs but they were ignored
and anyway lemon tabs didn't support a data-attr on the tab itself...
and so...