chore: move max spinner icon #33562
Merged
chore: move max spinner icon #33562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Improves UI consistency in the Max chat interface by relocating the loading spinner to the left side of reasoning messages, ensuring a fixed position regardless of message length.
- Modifies element ordering in
frontend/src/scenes/max/Thread.tsxto place spinner on left side of text - Change aligns with UX best practices for consistent loading indicator placement
- UI improvement maintains visual stability during state changes
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
sortafreel
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Problem
As @corywatilo highlighted, if we put the loading spinner on the left of a reasoning message in the Max message thread, it will be in a consistent location even when the text string changes.
Changes
Did you write or update any docs for this change?
How did you test this code?
Tested locally