feat: asset checks for web analytics pre-aggregated data #33572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still not ready, but curious about CI on this one |
There was a problem hiding this comment.
PR Summary
Added comprehensive data quality checks for web analytics pre-aggregated assets in the Dagster pipeline, implementing automated validation and monitoring systems.
- Introduced
web_preaggregated_asset_checks.pywith configurable accuracy checks and weekly scheduled jobs for monitoring data quality - Added
check_tables_existutility inweb_preaggregated_ddl.pyto verify table/view existence and queryability in ClickHouse - Implemented daily and hourly table existence checks with detailed error handling and metadata reporting
- Added metric accuracy comparison between pre-aggregated and regular queries with configurable tolerance levels
3 files reviewed, 4 comments
Edit PR Review Bot Settings | Greptile
380a854 to
a7ec7a6
Compare
rafaeelaudibert
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The web analytics pre-aggregated data pipeline lacked data quality checks, making it difficult to detect data integrity issues, as it was relying on running ad-hoc queries all the time.
Changes
Testing