fix(cdp): exclude internal_destinations from pipeline-add-on check #33584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Summary
Modified data pipeline add-on check logic to exclude internal destinations from requiring premium Data Pipelines feature, ensuring core PostHog functionality remains accessible regardless of subscription status.
- Excluded
internal_destinationtype from data-pipelines-addon-check inposthog/api/hog_function.py - Added comprehensive lifecycle tests in
posthog/api/test/test_hog_function.pyto verify internal destinations work without Data Pipelines add-on - Improved template handling robustness by only applying template code/schema when template exists
- Fixed potential error where code attempted to access properties of non-existent template
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
benjackwhite
requested changes
Jun 12, 2025
posthog/migrations/0766_fix_sub_template_ids_to_template_ids.py
Outdated
Show resolved
Hide resolved
benjackwhite
approved these changes
Jun 12, 2025
benjackwhite
requested changes
Jun 12, 2025
…rt-of-data-pipelines-addon-check
…rt-of-data-pipelines-addon-check
…rt-of-data-pipelines-addon-check
benjackwhite
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Problem
internal_destinationsshould not be part of the pipeline error check. this will also resolve this issue for now https://posthog.slack.com/archives/C06GG249PR6/p1749671833470969Changes
internal_destinationfrom data-pipelines-addon-checkHow did you test this code?